netdev - Re: [PATCH v3 net-next 00/11] Replay and offload host VLAN entries in DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220216080140.2b16ee78@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 16 Feb 2022 08:01:40 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Jiri Pirko <jiri@...dia.com>, Ido Schimmel <idosch@...dia.com>,
        Rafael Richter <rafael.richter@....de>,
        Daniel Klauer <daniel.klauer@....de>,
        Tobias Waldekranz <tobias@...dekranz.com>
Subject: Re: [PATCH v3 net-next 00/11] Replay and offload host VLAN entries
 in DSA

On Tue, 15 Feb 2022 19:02:07 +0200 Vladimir Oltean wrote:
> v2->v3:
> - make the bridge stop notifying switchdev for !BRENTRY VLANs
> - create precommit and commit wrappers around __vlan_add_flags().
> - special-case the BRENTRY transition from false to true, instead of
>   treating it as a change of flags and letting drivers figure out that
>   it really isn't.
> - avoid setting *changed unless we know that functions will not error
>   out later.
> - drop "old_flags" from struct switchdev_obj_port_vlan, nobody needs it
>   now, in v2 only DSA needed it to filter out BRENTRY transitions, that
>   is now solved cleaner.
> - no BRIDGE_VLAN_INFO_BRENTRY flag checks and manipulations in DSA
>   whatsoever, use the "bool changed" bit as-is after changing what it
>   means.
> - merge dsa_slave_host_vlan_{add,del}() with
>   dsa_slave_foreign_vlan_{add,del}(), since now they do the same thing,
>   because the host_vlan functions no longer need to mangle the vlan
>   BRENTRY flags and bool changed.

Appears applied, commit f0ead99e623b ("Merge branch
'Replay-and-offload-host-VLAN-entries-in-DSA'") in net-next, thanks!