lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220216164752.2794456-1-vladimir.oltean@nxp.com>
Date:   Wed, 16 Feb 2022 18:47:47 +0200
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Ido Schimmel <idosch@...dia.com>,
        Petr Machata <petrm@...dia.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Steen Hegelund <Steen.Hegelund@...rochip.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Karsten Graul <kgraul@...ux.ibm.com>,
        linux-omap@...r.kernel.org
Subject: [PATCH net-next 0/5] Remove BRENTRY checks from switchdev drivers

As discussed here:
https://patchwork.kernel.org/project/netdevbpf/patch/20220214233111.1586715-2-vladimir.oltean@nxp.com/#24738869

no switchdev driver makes use of VLAN port objects that lack the
BRIDGE_VLAN_INFO_BRENTRY flag. Notifying them in the first place rather
seems like an omission of commit 9c86ce2c1ae3 ("net: bridge: Notify
about bridge VLANs").

Since commit 3116ad0696dd ("net: bridge: vlan: don't notify to switchdev
master VLANs without BRENTRY flag") that was just merged, the bridge no
longer notifies switchdev upon creation of these VLANs, so we can remove
the checks from drivers.

Vladimir Oltean (5):
  mlxsw: spectrum: remove guards against !BRIDGE_VLAN_INFO_BRENTRY
  net: lan966x: remove guards against !BRIDGE_VLAN_INFO_BRENTRY
  net: sparx5: remove guards against !BRIDGE_VLAN_INFO_BRENTRY
  net: ti: am65-cpsw-nuss: remove guards against
    !BRIDGE_VLAN_INFO_BRENTRY
  net: ti: cpsw: remove guards against !BRIDGE_VLAN_INFO_BRENTRY

 drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c  |  4 +---
 .../net/ethernet/mellanox/mlxsw/spectrum_switchdev.c |  3 +--
 .../ethernet/microchip/lan966x/lan966x_switchdev.c   | 12 ------------
 .../net/ethernet/microchip/sparx5/sparx5_switchdev.c | 10 ++++------
 drivers/net/ethernet/ti/am65-cpsw-switchdev.c        |  4 ----
 drivers/net/ethernet/ti/cpsw_switchdev.c             |  4 ----
 6 files changed, 6 insertions(+), 31 deletions(-)

-- 
2.25.1

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ