netdev - Re: [PATCH v3 net-next 1/1] net: Add new protocol attribute to IP addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220216165250.3dyyvl5gnaixcrh4@westermo.com>
Date:   Wed, 16 Feb 2022 17:52:50 +0100
From:   Jacques de Laval <Jacques.De.Laval@...termo.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     David Ahern <dsahern@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 net-next 1/1] net: Add new protocol attribute to IP
 addresses

On Tue, Feb 15, 2022 at 08:47:28PM -0800, Jakub Kicinski wrote:
> On Mon, 14 Feb 2022 16:59:06 +0100 Jacques de Laval wrote:
> > @@ -4626,6 +4631,7 @@ static const struct nla_policy ifa_ipv6_policy[IFA_MAX+1] = {
> >  	[IFA_FLAGS]		= { .len = sizeof(u32) },
> >  	[IFA_RT_PRIORITY]	= { .len = sizeof(u32) },
> >  	[IFA_TARGET_NETNSID]	= { .type = NLA_S32 },
> > +	[IFA_PROTO]             = { .len = sizeof(u8) },
> >  };
> 
> Is there a reason this is not using type = NLA_U8?
> 

Thanks for spotting this Jakub. I use type = NLA_U8 for ifa_ipv4_policy
and it should be the same here. Will fix in v4.

Thanks,
Jacques