netdev - Re: [PATCH] net: ethernet: xilinx: cleanup comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54168947-f587-2209-b6df-80aefb968123@xilinx.com>
Date:   Wed, 16 Feb 2022 08:41:42 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     <trix@...hat.com>, <davem@...emloft.net>, <kuba@...nel.org>,
        <michal.simek@...inx.com>, <radhey.shyam.pandey@...inx.com>,
        <gary@...yguo.net>, <rdunlap@...radead.org>, <esben@...nix.com>,
        <huangguangbin2@...wei.com>, <michael@...le.cc>,
        <moyufeng@...wei.com>, <arnd@...db.de>, <chenhao288@...ilicon.com>,
        <andrew@...n.ch>, <prabhakar.mahadev-lad.rj@...renesas.com>,
        <yuehaibing@...wei.com>
CC:     <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: ethernet: xilinx: cleanup comments



On 2/15/22 20:04, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Remove the second 'the'.
> Replacements:
> endiannes to endianness
> areconnected to are connected
> Mamagement to Management
> undoccumented to undocumented
> Xilink to Xilinx
> strucutre to structure
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   drivers/net/ethernet/xilinx/Kconfig               | 2 +-
>   drivers/net/ethernet/xilinx/ll_temac.h            | 4 ++--
>   drivers/net/ethernet/xilinx/ll_temac_main.c       | 2 +-
>   drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
>   drivers/net/ethernet/xilinx/xilinx_emaclite.c     | 2 +-
>   5 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
> index 911b5ef9e680..0014729b8865 100644
> --- a/drivers/net/ethernet/xilinx/Kconfig
> +++ b/drivers/net/ethernet/xilinx/Kconfig
> @@ -1,6 +1,6 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   #
> -# Xilink device configuration
> +# Xilinx device configuration
>   #
>   
>   config NET_VENDOR_XILINX
> diff --git a/drivers/net/ethernet/xilinx/ll_temac.h b/drivers/net/ethernet/xilinx/ll_temac.h
> index 4a73127e10a6..ad8d29f84be6 100644
> --- a/drivers/net/ethernet/xilinx/ll_temac.h
> +++ b/drivers/net/ethernet/xilinx/ll_temac.h
> @@ -271,7 +271,7 @@ This option defaults to enabled (set) */
>   
>   #define XTE_TIE_OFFSET			0x000003A4 /* Interrupt enable */
>   
> -/**  MII Mamagement Control register (MGTCR) */
> +/**  MII Management Control register (MGTCR) */


When you touch this you should remove /** which points to kernel-doc format.

When fixed you can add my
Reviewed-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal