netdev - Re: [net-next PATCH 0/2] Add ethtool support for completion event size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Feb 2022 09:01:10 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Subbaraya Sundeep <sbhatta@...vell.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <sundeep.lkml@...il.com>, <hkelam@...vell.com>,
        <gakula@...vell.com>, <sgoutham@...vell.com>
Subject: Re: [net-next PATCH 0/2] Add ethtool support for completion event
 size

On Thu, 17 Feb 2022 20:19:04 +0530 Subbaraya Sundeep wrote:
> After a packet is sent or received by NIC then NIC posts
> a completion event which consists of transmission status
> (like send success or error) and received status(like
> pointers to packet fragments). These completion events may
> also use a ring similar to rx and tx rings. This patchset
> introduces ce-size ethtool parameter to modify the size
> of the completion event if NIC hardware has that capability.
> A bigger completion event can have more receive buffer pointers
> inturn NIC can transfer a bigger frame from wire as long as
> hardware(MAC) receive frame size limit is not exceeded.
> 
> Patch 1 adds support setting/getting ce-size via
> ethtool -G and ethtool -g.
> 
> Patch 2 includes octeontx2 driver changes to use
> completion event size set from ethtool -G.

Please add an explanation to ethtool-netlink.rst so people can
understand what the semantics are.

I think we may want to rename CE -> CQE, we used cqe for IRQ config.

Does changing the CQE size also change the size of the completion ring?
Or does it only control aggregation / writeback size?