netdev - Re: [PATCH net v3 1/1] openvswitch: Fix setting ipv6 fields causing hw csum failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220217094257.5c35acc3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 17 Feb 2022 09:42:57 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Paul Blakey <paulb@...dia.com>
Cc:     <dev@...nvswitch.org>, <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        "Pravin B Shelar" <pshelar@....org>, <davem@...emloft.net>,
        Eelco Chaudron <echaudro@...hat.com>,
        Oz Shlomo <ozsh@...dia.com>, Vlad Buslov <vladbu@...dia.com>,
        Roi Dayan <roid@...dia.com>,
        Ariel Levkovich <lariel@...dia.com>
Subject: Re: [PATCH net v3 1/1] openvswitch: Fix setting ipv6 fields causing
 hw csum failure

On Wed, 16 Feb 2022 15:53:08 +0200 Paul Blakey wrote:
> +		skb->csum =
> +			~csum_block_add(csum_block_sub(~skb->csum,
> +						       (__force __wsum) (ipv6_tclass << 4), 1),
> +					(__force __wsum) (old_ipv6_tclass << 4), 1);

Please add a wcsum_replace4() helper to include/net/checksum.h
It should work like the (misnamed) csum_relace4() helper and have
similar params just wsum instead of sum16.