netdev - Re: [PATCH v7 net-next] net-core: add InDropOtherhost counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACB8nPmnJA7FYFZtRgF_RASOGZhCEFHcK3n0zbtT4OJ61gkrug@mail.gmail.com>
Date:   Fri, 18 Feb 2022 13:31:03 -0800
From:   Jeffrey Ji <jeffreyjilinux@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Brian Vazquez <brianvv@...gle.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        jeffreyji <jeffreyji@...gle.com>
Subject: Re: [PATCH v7 net-next] net-core: add InDropOtherhost counter

Hi Jakub, I'll remove the MIB counters & instead add counters to
rtnl_link_stats64 and rtnl_link_stats, does that sound right? But keep
the sbk_free_drop_reason


On Mon, Feb 7, 2022 at 7:51 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon,  7 Feb 2022 23:57:14 +0000 Jeffrey Ji wrote:
> > From: jeffreyji <jeffreyji@...gle.com>
> >
> > Increment InDropOtherhost counter when packet dropped due to incorrect dest
> > MAC addr.
> >
> > An example when this drop can occur is when manually crafting raw
> > packets that will be consumed by a user space application via a tap
> > device. For testing purposes local traffic was generated using trafgen
> > for the client and netcat to start a server
> >
> > example output from nstat:
> > \~# nstat -a | grep InMac
> > Ip6InDropOtherhost                  0                  0.0
> > IpExtInDropOtherhost                1                  0.0
> >
> > Tested: Created 2 netns, sent 1 packet using trafgen from 1 to the other
> > with "{eth(daddr=$INCORRECT_MAC...}", verified that nstat showed the
> > counter was incremented.
>
> As far as I can tell nobody objected to my suggestion of making this
> a netdev counter, so please switch to working on that. Thanks.