netdev - RE: [PATCH net-next 2/6] nfp: add support to offload tc action to hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR1301MB21723E0751D556E87ADA4EDFE7379@DM5PR1301MB2172.namprd13.prod.outlook.com>
Date:   Fri, 18 Feb 2022 08:03:10 +0000
From:   Baowen Zheng <baowen.zheng@...igine.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Simon Horman <simon.horman@...igine.com>
CC:     David Miller <davem@...emloft.net>,
        Louis Peens <louis.peens@...igine.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        oss-drivers <oss-drivers@...igine.com>
Subject: RE: [PATCH net-next 2/6] nfp: add support to offload tc action to
 hardware

On Friday, February 18, 2022 12:40 PM, Jakub:
>To: Simon Horman <simon.horman@...igine.com>
>Cc: David Miller <davem@...emloft.net>; Baowen Zheng
><baowen.zheng@...igine.com>; Louis Peens <louis.peens@...igine.com>;
>netdev@...r.kernel.org; oss-drivers <oss-drivers@...igine.com>
>Subject: Re: [PATCH net-next 2/6] nfp: add support to offload tc action to
>hardware
>
>On Thu, 17 Feb 2022 11:56:48 +0100 Simon Horman wrote:
>> +	if (add)
>> +		return 0;
>> +	else
>> +		return -EOPNOTSUPP;
>
>	return add ? 0 : -EOPNOTSUPP;
>
>or at least remove the else, everything after if () return; is in an 'else' branch.
Thanks, will make the change in V2 patch.