netdev - Re: [BUG/PATCH v3] net: mvpp2: always set port pcs ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220218204419.63962fbc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 18 Feb 2022 20:44:19 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Marcin Wojtas <mw@...ihalf.com>,
        Jeremy Linton <jeremy.linton@....com>
Cc:     netdev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [BUG/PATCH v3] net: mvpp2: always set port pcs ops

On Sat, 19 Feb 2022 00:49:27 +0100 Marcin Wojtas wrote:
> wt., 15 lut 2022 o 00:18 Jeremy Linton <jeremy.linton@....com> napisał(a):
> > Booting a MACCHIATObin with 5.17, the system OOPs with
> > a null pointer deref when the network is started. This
> > is caused by the pcs->ops structure being null in
> > mcpp2_acpi_start() when it tries to call pcs_config().
> >
> > Hoisting the code which sets pcs_gmac.ops and pcs_xlg.ops,
> > assuring they are always set, fixes the problem.

> > Fixes: cff056322372 ("net: mvpp2: use .mac_select_pcs() interface")
> > Suggested-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> > Signed-off-by: Jeremy Linton <jeremy.linton@....com>

> You can add my:
> Reviewed-by: Marcin Wojtas <mw@...ihalf.com>

Perfect, thanks everyone! 

It's now 5a2aba71cd26 ("net: mvpp2: always set port pcs ops") in net.