netdev - Re: [PATCH net v2] mctp: Fix incorrect netdev unref for extended addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220218214224.7b990673@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 18 Feb 2022 21:42:24 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Matt Johnston <matt@...econstruct.com.au>
Cc:     Jeremy Kerr <jk@...econstruct.com.au>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] mctp: Fix incorrect netdev unref for extended
 addr

On Fri, 18 Feb 2022 14:29:08 +0800 Matt Johnston wrote:
>  		rt->dev = __mctp_dev_get(dev);
> +		if (rt->dev)
> +			mctp_dev_hold(rt->dev);

Is it safe to have the ref like that? mctp_dev_hold() just does a
refcount_inc(), does something prevent the refcount from dropping
to zero between __mctp_dev_get() and mctp_dev_hold()?