netdev - Re: [PATCH net-next 08/12] vxlan: vni filtering support on collect metadata device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202202210620.Qp46jPJO-lkp@intel.com>
Date:   Mon, 21 Feb 2022 06:24:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Roopa Prabhu <roopa@...dia.com>, davem@...emloft.net,
        kuba@...nel.org
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        stephen@...workplumber.org, nikolay@...ulusnetworks.com,
        idosch@...dia.com, dsahern@...il.com
Subject: Re: [PATCH net-next 08/12] vxlan: vni filtering support on collect
 metadata device

Hi Roopa,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Roopa-Prabhu/vxlan-metadata-device-vnifiltering-support/20220220-220748
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 129c77b5692d4a95a00aa7d58075afe77179623e
config: m68k-randconfig-s032-20220220 (https://download.01.org/0day-ci/archive/20220221/202202210620.Qp46jPJO-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/5344344656a955610e1a596bf3de904d5c6647f4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Roopa-Prabhu/vxlan-metadata-device-vnifiltering-support/20220220-220748
        git checkout 5344344656a955610e1a596bf3de904d5c6647f4
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=m68k SHELL=/bin/bash drivers/net/vxlan/ kernel/time/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

>> drivers/net/vxlan/vxlan_multicast.c:181:5: warning: no previous prototype for 'vxlan_multicast_join_vnigrp' [-Wmissing-prototypes]
     181 | int vxlan_multicast_join_vnigrp(struct vxlan_dev *vxlan)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/vxlan/vxlan_multicast.c:218:5: warning: no previous prototype for 'vxlan_multicast_leave_vnigrp' [-Wmissing-prototypes]
     218 | int vxlan_multicast_leave_vnigrp(struct vxlan_dev *vxlan)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/net/vxlan/vxlan_multicast.c:12:
   drivers/net/vxlan/vxlan_private.h:13:17: warning: 'all_zeros_mac' defined but not used [-Wunused-const-variable=]
      13 | static const u8 all_zeros_mac[ETH_ALEN + 2];
         |                 ^~~~~~~~~~~~~
--
>> drivers/net/vxlan/vxlan_vnifilter.c:20:6: warning: no previous prototype for 'vxlan_vs_add_del_vninode' [-Wmissing-prototypes]
      20 | void vxlan_vs_add_del_vninode(struct vxlan_dev *vxlan,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/vxlan/vxlan_vnifilter.c: In function 'vxlan_vnifilter_dump_dev':
   drivers/net/vxlan/vxlan_vnifilter.c:202:39: warning: variable 'tmsg' set but not used [-Wunused-but-set-variable]
     202 |         struct tunnel_msg *new_tmsg, *tmsg;
         |                                       ^~~~
   drivers/net/vxlan/vxlan_vnifilter.c: In function 'vxlan_vni_alloc':
>> drivers/net/vxlan/vxlan_vnifilter.c:546:18: error: 'struct vxlan_vni_node' has no member named 'hlist6'; did you mean 'hlist4'?
     546 |         vninode->hlist6.vxlan = vxlan;
         |                  ^~~~~~
         |                  hlist4
   drivers/net/vxlan/vxlan_vnifilter.c: In function 'vxlan_vnigroup_uninit':
   drivers/net/vxlan/vxlan_vnifilter.c:731:40: error: 'struct vxlan_vni_node' has no member named 'hlist6'; did you mean 'hlist4'?
     731 |                 hlist_del_init_rcu(&v->hlist6.hlist);
         |                                        ^~~~~~
         |                                        hlist4


sparse warnings: (new ones prefixed by >>)
>> drivers/net/vxlan/vxlan_multicast.c:181:5: sparse: sparse: symbol 'vxlan_multicast_join_vnigrp' was not declared. Should it be static?
>> drivers/net/vxlan/vxlan_multicast.c:218:5: sparse: sparse: symbol 'vxlan_multicast_leave_vnigrp' was not declared. Should it be static?

vim +546 drivers/net/vxlan/vxlan_vnifilter.c

   535	
   536	static struct vxlan_vni_node *vxlan_vni_alloc(struct vxlan_dev *vxlan,
   537						      __be32 vni)
   538	{
   539		struct vxlan_vni_node *vninode;
   540	
   541		vninode = kzalloc(sizeof(*vninode), GFP_ATOMIC);
   542		if (!vninode)
   543			return NULL;
   544		vninode->vni = vni;
   545		vninode->hlist4.vxlan = vxlan;
 > 546		vninode->hlist6.vxlan = vxlan;
   547	
   548		return vninode;
   549	}
   550	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org