lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Feb 2022 13:03:50 +0300 From: Sergey Shtylyov <s.shtylyov@....ru> To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> CC: <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org> Subject: Re: [PATCH] ravb: Use GFP_KERNEL instead of GFP_ATOMIC when possible Hello! On 2/20/22 10:27 AM, Christophe JAILLET wrote: > 'max_rx_len' can be up to GBETH_RX_BUFF_MAX (i.e. 8192) (see > 'gbeth_hw_info'). > The default value of 'num_rx_ring' can be BE_RX_RING_SIZE (i.e. 1024). > > So this loop can allocate 8 Mo of memory. MB? :-) > > Previous memory allocations in this function already use GFP_KERNEL, so > use __netdev_alloc_skb() and an explicit GFP_KERNEL instead of a > implicit GFP_ATOMIC. > > This gives more opportunities of successful allocation. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru> [...] MBR, Sergey
Powered by blists - more mailing lists