netdev - Re: [PATCH net] net: dsa: fix panic when removing unoffloaded port from bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Feb 2022 22:45:56 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Alvin Šipraga <ALSI@...g-olufsen.dk>
Cc:     Alvin Šipraga <alvin@...s.dk>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Vladimir Oltean <vladimir.oltean@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: dsa: fix panic when removing unoffloaded port
 from bridge

On Mon, Feb 21, 2022 at 08:38:21PM +0000, Alvin Šipraga wrote:
> >> +	info.bridge = *dp->bridge,
> >
> > By the way, does this patch compile, with the comma and not the
> > semicolon, like that?
> 
> Yikes, sorry about that. Sent a corrected v2 now.
> 
> It does actually compile though.

Yes, I see, I think it probably works too:

	info.bridge = *dp->bridge, dsa_port_bridge_destroy(dp, br);

although I would never write code like that.