netdev - Re: [PATCH nf 2/5] netfilter: nf_tables_offload: incorrect flow offload action array size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhQRCVqtBfiHxChp@codewreck.org>
Date:   Tue, 22 Feb 2022 07:24:09 +0900
From:   Dominique Martinet <asmadeus@...ewreck.org>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netfilter-devel@...r.kernel.org, davem@...emloft.net,
        netdev@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH nf 2/5] netfilter: nf_tables_offload: incorrect flow
 offload action array size

Pablo Neira Ayuso wrote on Mon, Feb 21, 2022 at 05:17:54PM +0100:
> immediate verdict expression needs to allocate one slot in the flow offload
> action array, however, immediate data expression does not need to do so.
> 
> fwd and dup expression need to allocate one slot, this is missing.
> 
> Add a new offload_action interface to report if this expression needs to
> allocate one slot in the flow offload action array.
> 
> Fixes: be2861dc36d7 ("netfilter: nft_{fwd,dup}_netdev: add offload support")
> Reported-and-tested-by: Nick Gregory <Nick.Gregory@...hos.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

FYI this patch has been reported as fixing an arbitrary oob write on
oss-security just now:
https://www.openwall.com/lists/oss-security/2022/02/21/2

So it might make sense to send it quickly to Linus and linux-stable for
immediate backport as it will get some attention...
The poster didn't say anything about coordinating this with security
handling people so it's safe to assume that wasn't done.


Thanks,
-- 
Dominique