netdev - RE: [PATCH net-next v2 2/2] flow_offload: reject offload for all drivers with invalid police parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR1301MB21724BB2B0FF7C7A57BD1631E73B9@DM5PR1301MB2172.namprd13.prod.outlook.com>
Date:   Tue, 22 Feb 2022 10:29:57 +0000
From:   Baowen Zheng <baowen.zheng@...igine.com>
To:     Vladimir Oltean <vladimir.oltean@....com>,
        Jianbo Liu <jianbol@...dia.com>
CC:     "olteanv@...il.com" <olteanv@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        Petr Machata <petrm@...dia.com>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        oss-drivers <oss-drivers@...igine.com>,
        "hkelam@...vell.com" <hkelam@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "leon@...nel.org" <leon@...nel.org>,
        Nole Zhang <peng.zhang@...igine.com>,
        "louis.peens@...ronome.com" <louis.peens@...ronome.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "rajur@...lsio.com" <rajur@...lsio.com>,
        Ido Schimmel <idosch@...dia.com>,
        Simon Horman <simon.horman@...igine.com>,
        "sbhatta@...vell.com" <sbhatta@...vell.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        Roi Dayan <roid@...dia.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        Saeed Mahameed <saeedm@...dia.com>,
        "sgoutham@...vell.com" <sgoutham@...vell.com>,
        "gakula@...vell.com" <gakula@...vell.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next v2 2/2] flow_offload: reject offload for all
 drivers with invalid police parameters

Since almost all the drivers that support to offload police action make the similar validation, if it make sense to add the validation in the file of flow_offload.h or flow_offload.c?
Then the other drivers do not need to make the similar validation.
WDYT?

On Tuesday, February 22, 2022 6:10 PM, Vladimir wrote:
>On Tue, Feb 22, 2022 at 01:58:23AM +0000, Jianbo Liu wrote:
>> Hi Vladimir,
>>
>> I'd love to hear your suggestion regarding where this validate
>> function to be placed for drivers/net/ethernet/mscc, as it will be
>> used by both ocelot_net.c and ocelot_flower.c.
>>
>> Thanks!
>> Jianbo
>
>Try the attached patch on top of yours.