netdev - Re: [PATCH bpf-next v2 1/2] bpf: Add some description about BPF_JIT_ALWAYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW6bkhcDXb5k-46G_f4L+ot2QJwbY_-Urd+BEfrPWdmf+Q@mail.gmail.com>
Date:   Mon, 21 Feb 2022 18:01:05 -0800
From:   Song Liu <song@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next v2 1/2] bpf: Add some description about
 BPF_JIT_ALWAYS_ON in Kconfig

On Fri, Feb 18, 2022 at 7:15 PM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>
> When CONFIG_BPF_JIT_ALWAYS_ON is enabled, /proc/sys/net/core/bpf_jit_enable
> is permanently set to 1 and setting any other value than that will return
> in failure.
>
> Add the above description in the help text of config BPF_JIT_ALWAYS_ON, and
> then we can distinguish between BPF_JIT_ALWAYS_ON and BPF_JIT_DEFAULT_ON.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>  kernel/bpf/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
> index d24d518..cbf3f65 100644
> --- a/kernel/bpf/Kconfig
> +++ b/kernel/bpf/Kconfig
> @@ -58,6 +58,10 @@ config BPF_JIT_ALWAYS_ON
>           Enables BPF JIT and removes BPF interpreter to avoid speculative
>           execution of BPF instructions by the interpreter.
>
> +         When CONFIG_BPF_JIT_ALWAYS_ON is enabled, /proc/sys/net/core/bpf_jit_enable
> +         is permanently set to 1 and setting any other value than that will return
> +         in failure.

nit: "return failure" (no "in").

Other than this,

Acked-by: Song Liu <songliubraving@...com>

> +
>  config BPF_JIT_DEFAULT_ON
>         def_bool ARCH_WANT_DEFAULT_BPF_JIT || BPF_JIT_ALWAYS_ON
>         depends on HAVE_EBPF_JIT && BPF_JIT
> --
> 2.1.0
>