netdev - Re: [PATCH] net: bcmgenet: Return not supported if we don't have a WoL IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f79df42b-ff25-edaa-7bf3-00b44b126007@gmail.com>
Date:   Tue, 22 Feb 2022 08:42:24 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Peter Robinson <pbrobinson@...il.com>,
        Doug Berger <opendmb@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org
Cc:     Javier Martinez Canillas <javierm@...hat.com>
Subject: Re: [PATCH] net: bcmgenet: Return not supported if we don't have a
 WoL IRQ



On 2/22/2022 1:53 AM, Peter Robinson wrote:
> The ethtool WoL enable function wasn't checking if the device
> has the optional WoL IRQ and hence on platforms such as the
> Raspberry Pi 4 which had working ethernet prior to the last
> fix regressed with the last fix, so also check if we have a
> WoL IRQ there and return ENOTSUPP if not.
> 
> Fixes: 9deb48b53e7f ("bcmgenet: add WOL IRQ check")
> Fixes: 8562056f267d ("net: bcmgenet: request Wake-on-LAN interrupt")
> Signed-off-by: Peter Robinson <pbrobinson@...il.com>
> Suggested-by: Javier Martinez Canillas <javierm@...hat.com>
> ---
>   drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> We're seeing this crash on the Raspberry Pi 4 series of devices on
> Fedora on 5.17-rc with the top Fixes patch and wired ethernet doesn't work.

Are you positive these two things are related to one another? The 
transmit queue timeout means that the TX DMA interrupt is not firing up 
what is the relationship with the absence/presence of the Wake-on-LAN 
interrupt line?

At any rate:

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian