netdev - Re: [PATCH] net: bcmgenet: Return not supported if we don't have a WoL IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220222154225.41a6a2d0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 22 Feb 2022 15:42:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Peter Robinson <pbrobinson@...il.com>
Cc:     Doug Berger <opendmb@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        Javier Martinez Canillas <javierm@...hat.com>
Subject: Re: [PATCH] net: bcmgenet: Return not supported if we don't have a
 WoL IRQ

On Tue, 22 Feb 2022 09:53:48 +0000 Peter Robinson wrote:
> +	/* We need a WoL IRQ to enable support, not all HW has one setup */
> +	if (priv->wol_irq <= 0)
> +		return -ENOTSUPP;

EOPNOTSUPP, ignore the existing code in this function and trust
checkpatch's warning. ENOTSUPP should be avoided.