netdev - Re: [PATCH v4 net-next 08/11] net: dsa: remove "ds" and "port" from struct dsa_switchdev_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76558b81-a5ea-ad23-07a5-d6f9ebfe9956@gmail.com>
Date:   Mon, 21 Feb 2022 19:50:56 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Ansuel Smith <ansuelsmth@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        DENG Qingfang <dqfext@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        UNGLinuxDriver@...rochip.com, Jiri Pirko <jiri@...nulli.us>,
        Ivan Vecera <ivecera@...hat.com>
Subject: Re: [PATCH v4 net-next 08/11] net: dsa: remove "ds" and "port" from
 struct dsa_switchdev_event_work



On 2/21/2022 1:23 PM, Vladimir Oltean wrote:
> By construction, the struct net_device *dev passed to
> dsa_slave_switchdev_event_work() via struct dsa_switchdev_event_work
> is always a DSA slave device.
> 
> Therefore, it is redundant to pass struct dsa_switch and int port
> information in the deferred work structure. This can be retrieved at all
> times from the provided struct net_device via dsa_slave_to_port().
> 
> For the same reason, we can drop the dsa_is_user_port() check in
> dsa_fdb_offload_notify().
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian