netdev - Re: [PATCH] bpf: move the bpf syscall sysctl table to its own module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Feb 2022 21:06:44 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yan Zhu <zhuyan34@...wei.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        Linux-Fsdevel <linux-fsdevel@...r.kernel.org>,
        zengweilin@...wei.com, liucheng32@...wei.com,
        Xiaoming Ni <nixiaoming@...wei.com>, xiechengliang1@...wei.com
Subject: Re: [PATCH] bpf: move the bpf syscall sysctl table to its own module

On Tue, Feb 22, 2022 at 5:35 PM Yan Zhu <zhuyan34@...wei.com> wrote:
>
> Sysctl table is easier to read under its own module.

"own module"?
What are you talking about?
It's not "easier to read" and looks like a pointless churn.

> Signed-off-by: Yan Zhu <zhuyan34@...wei.com>
> ---
>  kernel/bpf/syscall.c | 80 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  kernel/sysctl.c      | 71 ----------------------------------------------
>  2 files changed, 80 insertions(+), 71 deletions(-)