netdev - Re: [PATCH] ipv6: prevent a possible race condition with lifetimes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220222164317.4c7f6bcf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 22 Feb 2022 16:43:17 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Niels Dossche <niels.dossche@...nt.be>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: prevent a possible race condition with lifetimes

On Sun, 20 Feb 2022 18:54:40 +0100 Niels Dossche wrote:
> valid_lft, prefered_lft and tstamp are always accessed under the lock
> "lock" in other places. Reading these without taking the lock may result
> in inconsistencies regarding the calculation of the valid and preferred
> variables since decisions are taken on these fields for those variables.
> 
> Signed-off-by: Niels Dossche <niels.dossche@...nt.be>

Looks like your email client has replaced tabs with spaces, 
so the patch won't apply. Could you try resending with git send-email?
Please add Dave's review tag in the next version, and the subject
tag should be [PATCH net v2]. Thanks!