netdev - Re: [PATCH libnetfilter_queue] libnetfilter_queue: add support of skb->priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e926bd60-7653-f528-ec15-2758a4ffc89a@6wind.com>
Date:   Wed, 23 Feb 2022 10:01:48 +0100
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>,
        Florian Westphal <fw@...len.de>
Cc:     netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH libnetfilter_queue] libnetfilter_queue: add support of
 skb->priority


Le 04/02/2022 à 15:20, Pablo Neira Ayuso a écrit :
> On Fri, Feb 04, 2022 at 01:01:26PM +0100, Florian Westphal wrote:
>> Nicolas Dichtel <nicolas.dichtel@...nd.com> wrote:
>>>
>>> Le 04/02/2022 à 11:26, Nicolas Dichtel a écrit :
>>>> Available since linux v5.18.
>>>>
>>>> Link: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=
>>>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>>>> ---
>>>
>>> Should I send another patch for the 'set' part?
>>> In this case, a nfq_set_verdict3(). The name is a bit ugly ;-)
>>> Any suggestions?
>>
>> I think we should just let the old api die and tell users
>> to use the mnl interface, that allows to add the new attribute
>> as soon as its available.
> 
> We have to provide a simple API based on mnl which ressembles the
> existing old API.
> 
> Feedback in these years is that there are a users that do not need to
> know about netlink details / advanced handling.
If I understand well, libnetfilter_queue is deprecated?
If this is right, maybe it could be advertised on the project page:
https://netfilter.org/projects/libnetfilter_queue/index.html


Regards,
Nicolas