netdev - Re: [PATCH net-next 1/1] ice: add TTY for GNSS module for E810T device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220223203729.GA22419@hoboy.vegasvil.org>
Date:   Wed, 23 Feb 2022 12:37:29 -0800
From:   Richard Cochran <richardcochran@...il.com>
To:     "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Cc:     "Mekala, SunithaX D" <sunithax.d.mekala@...el.com>,
        "Mishra, Sudhansu Sekhar" <sudhansu.mishra@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "Kolacinski, Karol" <karol.kolacinski@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/1] ice: add TTY for GNSS module for E810T
 device

On Wed, Feb 23, 2022 at 07:20:43PM +0000, Nguyen, Anthony L wrote:

> I haven't heard anything back. Are we ok with this convention? Just to
> add this usage is fairly standard for our driver structures especially
> in this ice_adminq.h file.

I would put the #defines just above the struct, but maybe that is more
of a personal preference of mine.  I don't think there is a tree wide
CodingStyle rule about this.

Thanks,
Richard