netdev - Re: [PATCH iproute2-next v2 1/3] mptcp: add fullmesh check for adding address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220222190859.4b79cbf4@hermes.local>
Date:   Tue, 22 Feb 2022 19:08:59 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Geliang Tang <geliang.tang@...e.com>
Cc:     David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
        mptcp@...ts.linux.dev,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>
Subject: Re: [PATCH iproute2-next v2 1/3] mptcp: add fullmesh check for
 adding address

On Wed, 23 Feb 2022 10:59:47 +0800
Geliang Tang <geliang.tang@...e.com> wrote:

> +			if (adding &&
> +			    (flags & MPTCP_PM_ADDR_FLAG_SIGNAL) &&
> +			    (flags & MPTCP_PM_ADDR_FLAG_FULLMESH))
> +				invarg("invalid flags\n", *argv)

There is a duplicate newline here, the message already gets newline from invarg().
If possible could you give explanation to the user.

Looks like mptcp has this in lots of places, and would be helpful
to give better response.