netdev - Re: [PATCH 1/1 net-next] net: bridge: add support for host l2 mdb entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220224080611.4e32bac3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 24 Feb 2022 08:06:11 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Nikolay Aleksandrov <razor@...ckwall.org>
Cc:     Joachim Wiberg <troglobit@...il.com>,
        Roopa Prabhu <roopa@...dia.com>, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH 1/1 net-next] net: bridge: add support for host l2 mdb
 entries

On Thu, 24 Feb 2022 13:26:22 +0200 Nikolay Aleksandrov wrote:
> On 23/02/2022 19:24, Joachim Wiberg wrote:
> > This patch expands on the earlier work on layer-2 mdb entries by adding
> > support for host entries.  Due to the fact that host joined entries do
> > not have any flag field, we infer the permanent flag when reporting the
> > entries to userspace, which otherwise would be listed as 'temp'.
> > 
> > Before patch:
> > 
> >     ~# bridge mdb add dev br0 port br0 grp 01:00:00:c0:ff:ee permanent
> >     Error: bridge: Flags are not allowed for host groups.
> >     ~# bridge mdb add dev br0 port br0 grp 01:00:00:c0:ff:ee
> >     Error: bridge: Only permanent L2 entries allowed.
> > 
> > After patch:
> > 
> >     ~# bridge mdb add dev br0 port br0 grp 01:00:00:c0:ff:ee permanent
> >     ~# bridge mdb show
> >     dev br0 port br0 grp 01:00:00:c0:ff:ee permanent vid 1
> > 
> > Signed-off-by: Joachim Wiberg <troglobit@...il.com>
>
> It would be nice to add a selftest for L2 entries. You can send it as a follow-up.

Let's wait for that, also checkpatch says you need to balance brackets
to hold kernel coding style.

> Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>