netdev - Re: [PATCH net-next v7 6/8] net/funeth: add the data path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOkoqZnu0Hqr-waa77a5wB4Nt6G5KS_HR3R4x9MDFYBVGhayvw@mail.gmail.com>
Date:   Thu, 24 Feb 2022 10:47:00 -0800
From:   Dimitris Michailidis <d.michailidis@...gible.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next v7 6/8] net/funeth: add the data path

On Wed, Feb 23, 2022 at 8:55 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 18 Feb 2022 15:45:34 -0800 Dimitris Michailidis wrote:
> > +     if (unlikely(skb->len < FUN_TX_MIN_LEN)) {
> > +             FUN_QSTAT_INC(q, tx_len_err);
> > +             return 0;
> > +     }
>
> Is there something in the standards that says 32 byte frames are
> invalid? __skb_put_padto() is your friend.

I'll remove this altogether. FW has its own handling for this case,
which also covers small packets from the XDP path.