netdev - Re: [PATCH] net: phy: phylink: check the return value of phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YhifJcE98boImuHJ@shell.armlinux.org.uk>
Date:   Fri, 25 Feb 2022 09:19:33 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: phylink: check the return value of
 phylink_validate()

On Fri, Feb 25, 2022 at 01:12:46AM -0800, Jia-Ju Bai wrote:
> The function phylink_validate() can fail, so its return value should be
> checked.
> 
> Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> Reported-by: TOTE Robot <oslab@...nghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>
> ---
>  drivers/net/phy/phylink.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 420201858564..597f7579b29f 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -584,7 +584,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>  
>  	bitmap_fill(pl->supported, __ETHTOOL_LINK_MODE_MASK_NBITS);
>  	linkmode_copy(pl->link_config.advertising, pl->supported);
> -	phylink_validate(pl, pl->supported, &pl->link_config);
> +	ret = phylink_validate(pl, pl->supported, &pl->link_config);
> +	if (ret)
> +		return ret;

Completely unnecessary. pl->supported will be zero, leading to
phy_lookup_setting() failing.

>  	s = phy_lookup_setting(pl->link_config.speed, pl->link_config.duplex,
>  			       pl->supported, true);
> @@ -1261,7 +1263,11 @@ struct phylink *phylink_create(struct phylink_config *config,
>  
>  	bitmap_fill(pl->supported, __ETHTOOL_LINK_MODE_MASK_NBITS);
>  	linkmode_copy(pl->link_config.advertising, pl->supported);
> -	phylink_validate(pl, pl->supported, &pl->link_config);
> +	ret = phylink_validate(pl, pl->supported, &pl->link_config);
> +	if (ret < 0) {
> +		kfree(pl);
> +		return ERR_PTR(ret);
> +	}

Again, intentional not to be checking here.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!