netdev - Re: [PATCH RFC net-next 5/6] net: dsa: sja1105: convert to phylink_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220225104445.pibnr7vyc5m42nrv@skbuf>
Date:   Fri, 25 Feb 2022 12:44:45 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc:     Marek Beh__n <kabel@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH RFC net-next 5/6] net: dsa: sja1105: convert to
 phylink_generic_validate()

On Thu, Feb 24, 2022 at 04:15:36PM +0000, Russell King (Oracle) wrote:
> Populate the MAC capabilities for the SJA1105 DSA switch using the same
> decision making which sja1105_phylink_validate() uses. Remove the now
> obsolete sja1105_phylink_validate() implementation to allow DSA to use
> phylink_generic_validate() for this switch driver.
> 
> As noted by Vladimir, this fixes an inconsequential bug which allowed
> gigabit and lower interface modes to be indicated when operating in
> 2500base-X mode.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>