netdev - Re: [PATCH net-next 1/6] net: dsa: sja1105: populate supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220225121556.u7cfh2hi7nq443jm@skbuf>
Date:   Fri, 25 Feb 2022 14:15:56 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     Marek Beh__n <kabel@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/6] net: dsa: sja1105: populate
 supported_interfaces

On Fri, Feb 25, 2022 at 12:08:02PM +0000, Russell King (Oracle) wrote:
> On Fri, Feb 25, 2022 at 01:58:58PM +0200, Vladimir Oltean wrote:
> > On Fri, Feb 25, 2022 at 11:56:02AM +0000, Russell King (Oracle) wrote:
> > > Populate the supported interfaces bitmap for the SJA1105 DSA switch.
> > > 
> > > This switch only supports a static model of configuration, so we
> > > restrict the interface modes to the configured setting.
> > > 
> > > Reviewed-by: Vladimir Oltean <olteanv@...il.com>                                Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> > 
> > These all appear on the same line, can you please fix and resend?
> 
> I hate vi/vim precisely because of this.
> 
> How this problem happens. I read the email in mutt under KDE's kconsole
> with your attributation. I select the attributation so it can be pasted.
> I edit the commit, which starts vi, move to the line containing my
> sign-off, hit 'i' and paste it in.
> 
> The result is a line that _looks_ in vi as being entirely correct. The
> next line follows on as if it is a separate line.
> 
> I save the commit message. When I look at it in "git log", again,
> everything looks good.
> 
> The only times that it can be identified is after sending and looking
> at it in mutt, and noticing that the Signed-off-by line appears to have
> a# '+' prefix, indicating that mutt wrapped the line - or after it gets
> merged into net-next when linux-next identifies the lack of s-o-b, by
> which time it's too late to fix.
> 
> How do others avoid this problem? Not use vi/vim, but use some other
> editor such as emacs or microemacs that doesn't have this crazy way of
> dealing with multiple lines?

I do this in vim all the time and never had this problem.
Maybe you're not realizing it's on the same line because you don't have
line numbers turned on? A long line wrapped by the vim viewer would be
obvious.

:set number

Compare (just a random bit of a commit message)

 20 Fixes: 869f0ec048dc ("arm64: dts: freescale: Fix 'interrupt-map' parent address cells")           │
 21 Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> Signed-off-by: Vladimir Oltean <vladimir.│
    oltean@....com>                                                                                   │
 22

with

Fixes: 869f0ec048dc ("arm64: dts: freescale: Fix 'interrupt-map' parent address cells")               │
Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> Signed-off-by: Vladimir Oltean <vladimir.    │
oltean@....com>                                                                                       │