netdev - Re: [PATCH net-next 1/3] net: ip: add skb drop reasons for ip egress path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADxym3Yuanr+ZKyAMu2yYD_Ld-=7GncatuhKFYpmc-Eq_QOB8g@mail.gmail.com>
Date:   Fri, 25 Feb 2022 21:53:56 +0800
From:   Menglong Dong <menglong8.dong@...il.com>
To:     Roman Mashak <mrv@...atatu.com>
Cc:     David Ahern <dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        David Miller <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Menglong Dong <imagedong@...cent.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Alexander Lobakin <alobakin@...me>,
        Cong Wang <cong.wang@...edance.com>, paulb@...dia.com,
        Talal Ahmad <talalahmad@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        flyingpeng@...cent.com, Mengen Sun <mengensun@...cent.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Yajun Deng <yajun.deng@...ux.dev>,
        Roopa Prabhu <roopa@...dia.com>,
        LKML <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/3] net: ip: add skb drop reasons for ip egress path

On Fri, Feb 25, 2022 at 9:41 PM Roman Mashak <mrv@...atatu.com> wrote:
>
> Menglong Dong <menglong8.dong@...il.com> writes:
>
> > On Tue, Feb 22, 2022 at 11:13 AM David Ahern <dsahern@...nel.org> wrote:
> >>
> >> On 2/20/22 8:57 AM, menglong8.dong@...il.com wrote:
> >> > From: Menglong Dong <imagedong@...cent.com>
> >> >
> >> > Replace kfree_skb() with kfree_skb_reason() in the packet egress path of
> >> > IP layer (both IPv4 and IPv6 are considered).
> >> >
> >> > Following functions are involved:
> >> >
> >> > __ip_queue_xmit()
> >> > ip_finish_output()
> >> > ip_mc_finish_output()
> >> > ip6_output()
> >> > ip6_finish_output()
> >> > ip6_finish_output2()
> >> >
> >> > Following new drop reasons are introduced:
> >> >
> >> > SKB_DROP_REASON_IP_OUTNOROUTES
> >> > SKB_DROP_REASON_BPF_CGROUP_EGRESS
> >> > SKB_DROP_REASON_IPV6DSIABLED
>
> Is this a typo and should be SKB_DROP_REASON_IPV6DISABLED ?

In fact......yeah, this is a typo :)
I'll fix it. Thanks!

>
> [...]
>