netdev - Re: [PATCH net-next v2] net/ip6mr: Fix build with !CONFIG_IPV6_PIMSM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0c27a7a-1ea9-6083-7d57-e9a23949c52f@kernel.org>
Date:   Fri, 25 Feb 2022 08:32:34 -0700
From:   David Ahern <dsahern@...nel.org>
To:     Dmitry Safonov <dima@...sta.com>, linux-kernel@...r.kernel.org
Cc:     Dmitry Safonov <0x7f454c46@...il.com>,
        Mobashshera Rasool <mobash.rasool.linux@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net/ip6mr: Fix build with
 !CONFIG_IPV6_PIMSM_V2

On 2/25/22 7:52 AM, Dmitry Safonov wrote:
> The following build-error on my config:
> net/ipv6/ip6mr.c: In function ‘ip6_mroute_setsockopt’:
> net/ipv6/ip6mr.c:1656:14: error: unused variable ‘do_wrmifwhole’ [-Werror=unused-variable]
>  1656 |         bool do_wrmifwhole;
>       |              ^
> 
> Cc: Mobashshera Rasool <mobash.rasool.linux@...il.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> Cc: David Ahern <dsahern@...nel.org>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: netdev@...r.kernel.org
> Fixes: 4b340a5a726d
> Signed-off-by: Dmitry Safonov <dima@...sta.com>
> ---
> v2: move the (v == MRT6MSG_WRMIFWHOLE) check under if (v != mrt->mroute_do_pim)
> 
>  net/ipv6/ip6mr.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>