netdev - RE: [PATCH] net: fec: ethtool: fix unbalanced IRQ wake disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 25 Feb 2022 03:07:41 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Sascha Hauer <s.hauer@...gutronix.de>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Ahmad Fatoum <a.fatoum@...gutronix.de>
Subject: RE: [PATCH] net: fec: ethtool: fix unbalanced IRQ wake disable


Hi Sascha,

> -----Original Message-----
> From: Sascha Hauer <s.hauer@...gutronix.de>
> Sent: 2022年2月23日 18:56
> To: Joakim Zhang <qiangqing.zhang@....com>
> Cc: netdev@...r.kernel.org; David S . Miller <davem@...emloft.net>;
> kernel@...gutronix.de; Ahmad Fatoum <a.fatoum@...gutronix.de>
> Subject: Re: [PATCH] net: fec: ethtool: fix unbalanced IRQ wake disable
> 
> On Wed, Feb 23, 2022 at 10:28:34AM +0000, Joakim Zhang wrote:
> >
> > Hi Sascha,
> >
> > > -----Original Message-----
> > > From: Sascha Hauer <s.hauer@...gutronix.de>
> > > Sent: 2022年2月23日 16:09
> > > To: netdev@...r.kernel.org
> > > Cc: Joakim Zhang <qiangqing.zhang@....com>; David S . Miller
> > > <davem@...emloft.net>; kernel@...gutronix.de; Ahmad Fatoum
> > > <a.fatoum@...gutronix.de>; Sascha Hauer <s.hauer@...gutronix.de>
> > > Subject: [PATCH] net: fec: ethtool: fix unbalanced IRQ wake disable
> > >
> > > From: Ahmad Fatoum <a.fatoum@...gutronix.de>
> > >
> > > Userspace can trigger a kernel warning by using the ethtool ioctls
> > > to disable WoL, when it was not enabled before:
> > >
> > >   $ ethtool -s eth0 wol d ; ethtool -s eth0 wol d
> > >   Unbalanced IRQ 54 wake disable
> > >   WARNING: CPU: 2 PID: 17532 at kernel/irq/manage.c:900
> > > irq_set_irq_wake+0x108/0x148
> > >
> > > This is because fec_enet_set_wol happily calls disable_irq_wake,
> > > even if the wake IRQ is already disabled.
> >
> > I have not found disable_irq_wake in fec_enet_set_wol.
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felix
> >
> ir.bootlin.com%2Flinux%2Fv5.17-rc5%2Fsource%2Fdrivers%2Fnet%2Fethern
> et
> > %2Ffreescale%2Ffec_main.c%23L2882&amp;data=04%7C01%7Cqiangqing.z
> hang%4
> >
> 0nxp.com%7C2d4ab9a7efa94043248a08d9f6bb1b04%7C686ea1d3bc2b4c6fa9
> 2cd99c
> >
> 5c301635%7C0%7C0%7C637812105743913684%7CUnknown%7CTWFpbGZsb3
> d8eyJWIjoi
> >
> MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300
> 0&amp;
> >
> sdata=Po%2F0sml1SjBSXlx8BTELg29hE5qsLIW2xyALy7O87s0%3D&amp;reserv
> ed=0
> >
> > > Looking at other drivers, like lpc_eth, suggests the way to go is to
> > > do wake IRQ enabling/disabling in the suspend/resume callbacks.
> > > Doing so avoids the warning at no loss of functionality.
> >
> > FEC done as this way:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felix
> >
> ir.bootlin.com%2Flinux%2Fv5.17-rc5%2Fsource%2Fdrivers%2Fnet%2Fethern
> et
> > %2Ffreescale%2Ffec_main.c%23L4075&amp;data=04%7C01%7Cqiangqing.z
> hang%4
> >
> 0nxp.com%7C2d4ab9a7efa94043248a08d9f6bb1b04%7C686ea1d3bc2b4c6fa9
> 2cd99c
> >
> 5c301635%7C0%7C0%7C637812105743913684%7CUnknown%7CTWFpbGZsb3
> d8eyJWIjoi
> >
> MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300
> 0&amp;
> >
> sdata=H9kdNlPJ1KPOyvS%2FLm%2Bj6NrPe5N1mD%2BrfgWoNhEUYgU%3D&
> amp;reserve
> > d=0
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felix
> >
> ir.bootlin.com%2Flinux%2Fv5.17-rc5%2Fsource%2Fdrivers%2Fnet%2Fethern
> et
> > %2Ffreescale%2Ffec_main.c%23L4119&amp;data=04%7C01%7Cqiangqing.z
> hang%4
> >
> 0nxp.com%7C2d4ab9a7efa94043248a08d9f6bb1b04%7C686ea1d3bc2b4c6fa9
> 2cd99c
> >
> 5c301635%7C0%7C0%7C637812105743913684%7CUnknown%7CTWFpbGZsb3
> d8eyJWIjoi
> >
> MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300
> 0&amp;
> >
> sdata=MH30p5o2fjlp%2FLXzMSPP20I7RToQNr9kYrTGl%2FZSHbw%3D&amp;r
> eserved=
> > 0
> >
> > > This only affects userspace with older ethtool versions. Newer ones
> > > use netlink and disabling before enabling will be refused before
> > > reaching the driver.
> >
> > Ahh, what I misunderstand? All the description makes me confusion.
> Please use the latest kernel.
> 
> This patch was forward ported from v5.16. I should have had a closer look
> before posting, then I maybe would have realized that 0b6f65c707e5
> ("net: fec: fix system hang during suspend/resume") already fixes the issue.
> 
> Sorry for the noise.

Never mind!! 😊

> Sascha
> 
> --
> Pengutronix e.K.                           |
> |
> Steuerwalder Str. 21                       |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> pengutronix.de%2F&amp;data=04%7C01%7Cqiangqing.zhang%40nxp.com%
> 7C2d4ab9a7efa94043248a08d9f6bb1b04%7C686ea1d3bc2b4c6fa92cd99c5c301
> 635%7C0%7C0%7C637812105743913684%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> 7C3000&amp;sdata=k7CPvHlnOgPbcqSuqtpQnlWs%2B3D0%2FeF3LViHQB%2
> BNpzQ%3D&amp;reserved=0  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0
> |
> Amtsgericht Hildesheim, HRA 2686           | Fax:
> +49-5121-206917-5555 |