netdev - Re: [PATCH net-next v2 11/12] drivers: vxlan: vnifilter: per vni stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79eed237-4659-7e86-ed26-93f70b1d47bc@nvidia.com>
Date:   Fri, 25 Feb 2022 09:49:20 -0800
From:   Roopa Prabhu <roopa@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        stephen@...workplumber.org, nikolay@...ulusnetworks.com,
        idosch@...dia.com, dsahern@...il.com, bpoirier@...dia.com
Subject: Re: [PATCH net-next v2 11/12] drivers: vxlan: vnifilter: per vni
 stats


On 2/23/22 20:02, Jakub Kicinski wrote:
> On Tue, 22 Feb 2022 02:52:29 +0000 Roopa Prabhu wrote:
>> @@ -164,7 +166,6 @@ int vxlan_vnilist_update_group(struct vxlan_dev *vxlan,
>>   			       union vxlan_addr *new_remote_ip,
>>   			       struct netlink_ext_ack *extack);
>>   
>> -
> spurious
>
>>   /* vxlan_multicast.c */
>>   int vxlan_multicast_join(struct vxlan_dev *vxlan);
>>   int vxlan_multicast_leave(struct vxlan_dev *vxlan);
>> +void vxlan_vnifilter_count(struct vxlan_dev *vxlan, __be32 vni,
>> +			   int type, unsigned int len)
>> +{
>> +	struct vxlan_vni_node *vninode;
>> +
>> +	if (!(vxlan->cfg.flags & VXLAN_F_VNIFILTER))
>> +		return;
>> +
>> +	vninode = vxlan_vnifilter_lookup(vxlan, vni);
>> +	if (!vninode)
>> +		return;
> Don't we end up calling vxlan_vnifilter_lookup() multiple times for
> every packet? Can't we remember the vninode from vxlan_vs_find_vni()?
>
you are right, its done this way to not propagate vninode into vxlan_rcv.

let me see what we can do here.thanks