netdev - Re: [PATCH 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yhkp9CH0SpBKKlzZ@robh.at.kernel.org>
Date:   Fri, 25 Feb 2022 13:11:48 -0600
From:   Rob Herring <robh@...nel.org>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Robert Marko <robert.marko@...tura.hr>,
        Baruch Siach <baruch.siach@...lu.com>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description

On Mon, Feb 21, 2022 at 04:33:22PM +0200, Baruch Siach wrote:
> From: Baruch Siach <baruch.siach@...lu.com>
> 
> The IPQ60xx has the same MDIO bug block as IPQ4019. Add IO range and
> clock resources description.
> 
> Signed-off-by: Baruch Siach <baruch.siach@...lu.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 5eb7dc9cc231..093011d18ca6 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -635,6 +635,16 @@ qrtr_requests {
>  			};
>  		};
>  
> +		mdio: mdio@...00 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			compatible = "qcom,ipq6018-mdio", "qcom,ipq4019-mdio";

This looks correct with the fallback based on your description, but it
doesn't match the schema.

You tested this with the schemas, right? That's why we have them.

> +			reg = <0x0 0x90000 0x0 0x64>;
> +			clocks = <&gcc GCC_MDIO_AHB_CLK>;
> +			clock-names = "gcc_mdio_ahb_clk";
> +			status = "disabled";
> +		};
> +
>  		qusb_phy_1: qusb@...00 {
>  			compatible = "qcom,ipq6018-qusb2-phy";
>  			reg = <0x0 0x059000 0x0 0x180>;
> -- 
> 2.34.1
> 
>