netdev - Re: [PATCH net] net: ipa: fix a build dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Feb 2022 12:52:16 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Alex Elder <elder@...aro.org>, davem@...emloft.net, kuba@...nel.org
Cc:     bjorn.andersson@...aro.org, mka@...omium.org, evgreen@...omium.org,
        cpratapa@...eaurora.org, avuyyuru@...eaurora.org,
        jponduru@...eaurora.org, subashab@...eaurora.org, elder@...nel.org,
        netdev@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: ipa: fix a build dependency



On 2/25/22 12:15, Alex Elder wrote:
> An IPA build problem arose in the linux-next tree the other day.
> The problem is that a recent commit adds a new dependency on some
> code, and the Kconfig file for IPA doesn't reflect that dependency.
> As a result, some configurations can fail to build (particularly
> when COMPILE_TEST is enabled).
> 
> The recent patch adds calls to qmp_get(), qmp_put(), and qmp_send(),
> and those are built based on the QCOM_AOSS_QMP config option.  If
> that symbol is not defined, stubs are defined, so we just need to
> ensure QCOM_AOSS_QMP is compatible with QCOM_IPA, or it's not
> defined.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Fixes: 34a081761e4e3 ("net: ipa: request IPA register values be retained")
> Signed-off-by: Alex Elder <elder@...aro.org>

Tested-by: Randy Dunlap <rdunlap@...radead.org>
Acked-by: Randy Dunlap <rdunlap@...radead.org>

thanks.

> ---
>  drivers/net/ipa/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig
> index d037682fb7adb..e0164a55c1e66 100644
> --- a/drivers/net/ipa/Kconfig
> +++ b/drivers/net/ipa/Kconfig
> @@ -3,6 +3,7 @@ config QCOM_IPA
>  	depends on NET && QCOM_SMEM
>  	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
> +	depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n
>  	select QCOM_MDT_LOADER if ARCH_QCOM
>  	select QCOM_SCM
>  	select QCOM_QMI_HELPERS

-- 
~Randy