netdev - Re: [PATCH net-internal v2 2/8] ibmvnic: initialize rc before completing wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220224211556.41874708@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 24 Feb 2022 21:15:56 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
Cc:     netdev@...r.kernel.org, Brian King <brking@...ux.ibm.com>,
        Dany Madden <drt@...ux.ibm.com>,
        Rick Lindsley <ricklind@...ux.ibm.com>
Subject: Re: [PATCH net-internal v2 2/8] ibmvnic: initialize rc before
 completing wait

On Thu, 24 Feb 2022 20:09:35 -0800 Sukadev Bhattiprolu wrote:
> We should initialize ->init_done_rc before calling complete(). Otherwise
> the waiting thread may see ->init_done_rc as 0 before we have updated it
> and may assume that the CRQ was successful.
> 
> Fixes: 6b278c0cb378 ("ibmvnic delay complete()")

As you resend please fix to:

Fixes: 6b278c0cb378 ("ibmvnic: delay complete()")

There's a : missing.

Also in patch three make reinit_init_done() non-inline to keep with 
the netdev recommendations.