netdev - Re: [PATCH net-next] nfp: make RSS can be switched on/off by ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 26 Feb 2022 17:29:42 +0800
From:   Yinjun Zhang <yinjun.zhang@...igine.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Simon Horman <simon.horman@...igine.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        oss-drivers@...igine.com, Louis Peens <louis.peens@...igine.com>
Subject: Re: [PATCH net-next] nfp: make RSS can be switched on/off by ethtool

On Fri, Feb 25, 2022 at 07:48:09AM -0800, Jakub Kicinski wrote:
> On Fri, 25 Feb 2022 09:59:29 +0100 Simon Horman wrote:
> > From: Yinjun Zhang <yinjun.zhang@...igine.com>
> > 
> > RSS is default on in nfp net device, and cannot be switched off
> > by `ethtool -K <int> receive-hashing off`. Implement it now.
> 
> Does rxhash mean RSS or reporting of the flow hash?
> User can "disable RSS" by changing the indirection table to all-0.
> Currently rxhash controls copying the rxhash to the skb for the nfp.

Seems you're right. `rxhash` is to enable/disable rx hash offload only.
But it seems that some few nic vendors also use it as the switch of RSS.
Anyway, thanks for correction, please ignore this patch.