netdev - Re: [PATCH bpf-next] bpf: add config to allow loading modules with BTF mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a979467-7bfb-68eb-57d6-f5294846bac4@iogearbox.net>
Date:   Mon, 28 Feb 2022 14:25:40 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Shung-Hsi Yu <shung-hsi.yu@...e.com>,
        Connor O'Brien <connoro@...gle.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
        Michal Suchánek <msuchanek@...e.de>
Subject: Re: [PATCH bpf-next] bpf: add config to allow loading modules with
 BTF mismatches

On 2/23/22 5:34 AM, Shung-Hsi Yu wrote:
> On Wed, Feb 23, 2022 at 01:28:14AM +0000, Connor O'Brien wrote:
>> BTF mismatch can occur for a separately-built module even when the ABI
>> is otherwise compatible and nothing else would prevent successfully
>> loading. Add a new config to control how mismatches are handled. By
>> default, preserve the current behavior of refusing to load the
>> module. If MODULE_ALLOW_BTF_MISMATCH is enabled, load the module but
>> ignore its BTF information.
>>
>> Suggested-by: Yonghong Song <yhs@...com>
>> Suggested-by: Michal Suchánek <msuchanek@...e.de>
>> Signed-off-by: Connor O'Brien <connoro@...gle.com>
> 
> Maybe reference the discussion thread as well?
> 
> Link: https://lore.kernel.org/bpf/CAADnVQJ+OVPnBz8z3vNu8gKXX42jCUqfuvhWAyCQDu8N_yqqwQ@mail.gmail.com/

LGTM, and added above into the commit log while applying. Thanks everyone!