netdev - Re: [PATCH net-next v4 2/3] net: dsa: tag_rtl8_4: add rtl8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Feb 2022 17:22:21 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Alvin Šipraga <ALSI@...g-olufsen.dk>
Cc:     Luiz Angelo Daros de Luca <luizluca@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "arinc.unal@...nc9.com" <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next v4 2/3] net: dsa: tag_rtl8_4: add rtl8_4t
 trailing variant

On Mon, Feb 28, 2022 at 12:13:28PM +0000, Alvin Šipraga wrote:
> Luiz Angelo Daros de Luca <luizluca@...il.com> writes:
> 
> > Realtek switches supports the same tag both before ethertype or between
> > payload and the CRC.
> >
> > Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>
> > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> 
> Hi Luiz,
> 
> Please note that you should normally put my Reviewed-by after your
> S-o-b. After your v1 (and assuming you remembered your S-o-b) it should
> be treated as append-only. Gives some chronology to the review process.

I don't know if this is a hard and fast rule, but it is also how I do
things, and how b4 applies the tags as well. But I've seen people do
otherwise too.