netdev - Re: [PATCH v2 sysctl-next] bpf: move the bpf syscall sysctl table to bpf module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df1146a2-c718-fa6c-ec35-de75ff27484f@iogearbox.net>
Date:   Mon, 28 Feb 2022 16:53:44 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Yan Zhu <zhuyan34@...wei.com>, mcgrof@...nel.org
Cc:     andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org,
        john.fastabend@...il.com, kafai@...com, keescook@...omium.org,
        kpsingh@...nel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, liucheng32@...wei.com,
        netdev@...r.kernel.org, nixiaoming@...wei.com,
        songliubraving@...com, xiechengliang1@...wei.com, yhs@...com,
        yzaikin@...gle.com, zengweilin@...wei.com
Subject: Re: [PATCH v2 sysctl-next] bpf: move the bpf syscall sysctl table to
 bpf module

Hi Yan,

On 2/23/22 11:28 AM, Yan Zhu wrote:
> Aggregating the code of the feature in the code file of the feature
> itself can improve readability and reduce merge conflicts. So move
> the bpf syscall sysctl table to kernel/bpf/syscall.c
> 
> Signed-off-by: Yan Zhu <zhuyan34@...wei.com>
> 
> ---
> v1->v2:
>    1.Added patch branch identifier sysctl-next.
>    2.Re-describe the reason for the patch submission.

I'm not applying it given there is very little value in this change, see also what
has been said earlier:

https://lore.kernel.org/bpf/CAADnVQKmBoQEG1+nmrCg2ePVncn9rZJX9R4eucP9ULiY=xVGjQ@mail.gmail.com/

Thanks,
Daniel