netdev - Re: [PATCH v2 1/2] dt-bindings: net: ipq4019-mdio: Add ipq6018 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1646016270.923889.47194.nullmailer@robh.at.kernel.org>
Date:   Sun, 27 Feb 2022 20:44:30 -0600
From:   Rob Herring <robh@...nel.org>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     devicetree@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Baruch Siach <baruch.siach@...lu.com>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        linux-arm-msm@...r.kernel.org,
        Robert Marko <robert.marko@...tura.hr>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: net: ipq4019-mdio: Add ipq6018 compatible

On Sun, 27 Feb 2022 10:18:33 +0200, Baruch Siach wrote:
> From: Baruch Siach <baruch.siach@...lu.com>
> 
> The IPQ60xx MDIO bus is the same as IPQ4019.
> 
> Change 'enum' to 'items' list to allow fallback to older compatible
> strings.
> 
> Signed-off-by: Baruch Siach <baruch.siach@...lu.com>
> ---
> 
> v2:
> 
>   Update the schema to allow fallback compatible (Rob Herring)
> ---
>  Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml: properties:compatible:items: 'anyOf' conditional failed, one must be fixed:
	['qcom,ipq4019-mdio', 'qcom,ipq5018-mdio', 'qcom,ipq6018-mdio'] is not of type 'object', 'boolean'
	'qcom,ipq4019-mdio' is not of type 'object', 'boolean'
	'qcom,ipq5018-mdio' is not of type 'object', 'boolean'
	'qcom,ipq6018-mdio' is not of type 'object', 'boolean'
	from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml: ignoring, error in schema: properties: compatible: items
Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.example.dt.yaml:0:0: /example-0/mdio@...00: failed to match any schema with compatible: ['qcom,ipq4019-mdio']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1598217

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.