netdev - Re: [PATCH nf] netfilter: fix use-after-free in __nf_register_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yh1AEzg4OHvcCECE@salvia>
Date:   Mon, 28 Feb 2022 22:35:15 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        netfilter-devel@...r.kernel.org, netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH nf] netfilter: fix use-after-free in
 __nf_register_net_hook()

On Sun, Feb 27, 2022 at 10:01:41AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> We must not dereference @new_hooks after nf_hook_mutex has been released,
> because other threads might have freed our allocated hooks already.
> 
> BUG: KASAN: use-after-free in nf_hook_entries_get_hook_ops include/linux/netfilter.h:130 [inline]
> BUG: KASAN: use-after-free in hooks_validate net/netfilter/core.c:171 [inline]
> BUG: KASAN: use-after-free in __nf_register_net_hook+0x77a/0x820 net/netfilter/core.c:438
> Read of size 2 at addr ffff88801c1a8000 by task syz-executor237/4430

Applied, thanks.