netdev - Re: [PATCH net-next] net: netsec: enable pp skb recycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC_iWjL7bTq6XQg9YoAo+BCUzA0Ha0DC7M4Jqe7R+_qJE9XR7w@mail.gmail.com>
Date:   Mon, 28 Feb 2022 11:40:42 +0200
From:   Ilias Apalodimas <ilias.apalodimas@...aro.org>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        lorenzo.bianconi@...hat.com
Subject: Re: [PATCH net-next] net: netsec: enable pp skb recycling

On Fri, 25 Feb 2022 at 17:30, Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>
> Similar to mvneta or mvpp2, enable page_pool skb recycling for netsec
> dirver.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---
>  drivers/net/ethernet/socionext/netsec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
> index 556bd353dd42..b0c5a44785fa 100644
> --- a/drivers/net/ethernet/socionext/netsec.c
> +++ b/drivers/net/ethernet/socionext/netsec.c
> @@ -1044,7 +1044,7 @@ static int netsec_process_rx(struct netsec_priv *priv, int budget)
>                                   "rx failed to build skb\n");
>                         break;
>                 }
> -               page_pool_release_page(dring->page_pool, page);
> +               skb_mark_for_recycle(skb);
>
>                 skb_reserve(skb, xdp.data - xdp.data_hard_start);
>                 skb_put(skb, xdp.data_end - xdp.data);
> --
> 2.35.1
>
I'll test it at some point just to make sure everything,  but this is
a standard change to enable recycling. So

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>