lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Feb 2022 14:24:13 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Jakob Koschel <jakobkoschel@...il.com> Cc: Linus Torvalds <torvalds@...ux-foundation.org>, linux-arch <linux-arch@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, Arnd Bergman <arnd@...db.de>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Andrew Morton <akpm@...ux-foundation.org>, Kees Cook <keescook@...omium.org>, Mike Rapoport <rppt@...nel.org>, "Gustavo A. R. Silva" <gustavo@...eddedor.com>, Brian Johannesmeyer <bjohannesmeyer@...il.com>, Cristiano Giuffrida <c.giuffrida@...nl>, "Bos, H.J." <h.j.bos@...nl>, Christophe JAILLET <christophe.jaillet@...adoo.fr>, Jason Gunthorpe <jgg@...pe.ca>, Rasmus Villemoes <linux@...musvillemoes.dk>, Nathan Chancellor <nathan@...nel.org>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-sgx@...r.kernel.org, drbd-dev@...ts.linbit.com, linux-block@...r.kernel.org, linux-iio@...r.kernel.org, linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org, linux1394-devel@...ts.sourceforge.net, amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org, nouveau@...ts.freedesktop.org, linux-rdma@...r.kernel.org, linux-media@...r.kernel.org, intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, linux-wireless@...r.kernel.org, linux-pm@...r.kernel.org, linux-scsi@...r.kernel.org, linux-staging@...ts.linux.dev, linux-usb@...r.kernel.org, linux-aspeed@...ts.ozlabs.org, bcm-kernel-feedback-list@...adcom.com, linux-tegra@...r.kernel.org, linux-mediatek@...ts.infradead.org, kvm@...r.kernel.org, linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org, linux-f2fs-devel@...ts.sourceforge.net, linux-fsdevel@...r.kernel.org, kgdb-bugreport@...ts.sourceforge.net, v9fs-developer@...ts.sourceforge.net, tipc-discussion@...ts.sourceforge.net, alsa-devel@...a-project.org Subject: Re: [PATCH 1/6] drivers: usb: remove usage of list iterator past the loop body On Mon, Feb 28, 2022 at 12:08:17PM +0100, Jakob Koschel wrote: > diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c > index 9040a0561466..0fd0307bc07b 100644 > --- a/drivers/usb/gadget/udc/at91_udc.c > +++ b/drivers/usb/gadget/udc/at91_udc.c > @@ -150,13 +150,14 @@ static void proc_ep_show(struct seq_file *s, struct at91_ep *ep) > if (list_empty (&ep->queue)) > seq_printf(s, "\t(queue empty)\n"); > > - else list_for_each_entry (req, &ep->queue, queue) { > - unsigned length = req->req.actual; > + else > + list_for_each_entry(req, &ep->queue, queue) { > + unsigned int length = req->req.actual; > > - seq_printf(s, "\treq %p len %d/%d buf %p\n", > - &req->req, length, > - req->req.length, req->req.buf); > - } > + seq_printf(s, "\treq %p len %d/%d buf %p\n", > + &req->req, length, > + req->req.length, req->req.buf); > + } Don't make unrelated white space changes. It just makes the patch harder to review. As you're writing the patch make note of any additional changes and do them later in a separate patch. Also a multi-line indent gets curly braces for readability even though it's not required by C. And then both sides would get curly braces. > spin_unlock_irqrestore(&udc->lock, flags); > } > > @@ -226,7 +227,7 @@ static int proc_udc_show(struct seq_file *s, void *unused) > > if (udc->enabled && udc->vbus) { > proc_ep_show(s, &udc->ep[0]); > - list_for_each_entry (ep, &udc->gadget.ep_list, ep.ep_list) { > + list_for_each_entry(ep, &udc->gadget.ep_list, ep.ep_list) { Another unrelated change. > if (ep->ep.desc) > proc_ep_show(s, ep); > } [ snip ] > diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c > index 7c38057dcb4a..bb59200f1596 100644 > --- a/drivers/usb/gadget/udc/net2272.c > +++ b/drivers/usb/gadget/udc/net2272.c > @@ -926,7 +926,8 @@ static int > net2272_dequeue(struct usb_ep *_ep, struct usb_request *_req) > { > struct net2272_ep *ep; > - struct net2272_request *req; > + struct net2272_request *req = NULL; > + struct net2272_request *tmp; > unsigned long flags; > int stopped; > > @@ -939,11 +940,13 @@ net2272_dequeue(struct usb_ep *_ep, struct usb_request *_req) > ep->stopped = 1; > > /* make sure it's still queued on this endpoint */ > - list_for_each_entry(req, &ep->queue, queue) { > - if (&req->req == _req) > + list_for_each_entry(tmp, &ep->queue, queue) { > + if (&tmp->req == _req) { > + req = tmp; > break; > + } > } > - if (&req->req != _req) { > + if (!req) { > ep->stopped = stopped; > spin_unlock_irqrestore(&ep->dev->lock, flags); > return -EINVAL; > @@ -954,7 +957,6 @@ net2272_dequeue(struct usb_ep *_ep, struct usb_request *_req) > dev_dbg(ep->dev->dev, "unlink (%s) pio\n", _ep->name); > net2272_done(ep, req, -ECONNRESET); > } > - req = NULL; Another unrelated change. These are all good changes but send them as separate patches. > ep->stopped = stopped; > > spin_unlock_irqrestore(&ep->dev->lock, flags); regards, dan carpenter
Powered by blists - more mailing lists