netdev - Re: [PATCH v2 6/7] octeon_ep: add Tx/Rx processing and interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Mar 2022 18:19:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Veerasenareddy Burru <vburru@...vell.com>, davem@...emloft.net,
        kuba@...nel.org, corbet@....net, netdev@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Abhijit Ayarekar <aayarekar@...vell.com>,
        Satananda Burla <sburla@...vell.com>
Subject: Re: [PATCH v2 6/7] octeon_ep: add Tx/Rx processing and interrupt
 support

Hi Veerasenareddy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.17-rc6 next-20220228]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Veerasenareddy-Burru/Add-octeon_ep-driver/20220301-130525
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 719fce7539cd3e186598e2aed36325fe892150cf
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220301/202203011844.8vlB6VII-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/e0d69d884293634bda9cacbf722024931c0194f2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Veerasenareddy-Burru/Add-octeon_ep-driver/20220301-130525
        git checkout e0d69d884293634bda9cacbf722024931c0194f2
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/net/ethernet/marvell/octeon_ep/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/marvell/octeon_ep/octep_main.c: In function 'octep_alloc_ioq_vectors':
   drivers/net/ethernet/marvell/octeon_ep/octep_main.c:53:38: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
      53 |                 oct->ioq_vector[i] = vzalloc(sizeof(*oct->ioq_vector[i]));
         |                                      ^~~~~~~
         |                                      kvzalloc
>> drivers/net/ethernet/marvell/octeon_ep/octep_main.c:53:36: warning: assignment to 'struct octep_ioq_vector *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      53 |                 oct->ioq_vector[i] = vzalloc(sizeof(*oct->ioq_vector[i]));
         |                                    ^
   drivers/net/ethernet/marvell/octeon_ep/octep_main.c:69:17: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
      69 |                 vfree(oct->ioq_vector[i]);
         |                 ^~~~~
         |                 kvfree
   cc1: some warnings being treated as errors


vim +53 drivers/net/ethernet/marvell/octeon_ep/octep_main.c

    33	
    34	/**
    35	 * octep_alloc_ioq_vectors() - Allocate Tx/Rx Queue interrupt info.
    36	 *
    37	 * @oct: Octeon device private data structure.
    38	 *
    39	 * Allocate resources to hold per Tx/Rx queue interrupt info.
    40	 * This is the information passed to interrupt handler, from which napi poll
    41	 * is scheduled and includes quick access to private data of Tx/Rx queue
    42	 * corresponding to the interrupt being handled.
    43	 *
    44	 * Return: 0, on successful allocation of resources for all queue interrupts.
    45	 *         -1, if failed to allocate any resource.
    46	 */
    47	static int octep_alloc_ioq_vectors(struct octep_device *oct)
    48	{
    49		int i;
    50		struct octep_ioq_vector *ioq_vector;
    51	
    52		for (i = 0; i < oct->num_oqs; i++) {
  > 53			oct->ioq_vector[i] = vzalloc(sizeof(*oct->ioq_vector[i]));
    54			if (!oct->ioq_vector[i])
    55				goto free_ioq_vector;
    56	
    57			ioq_vector = oct->ioq_vector[i];
    58			ioq_vector->iq = oct->iq[i];
    59			ioq_vector->oq = oct->oq[i];
    60			ioq_vector->octep_dev = oct;
    61		}
    62	
    63		dev_info(&oct->pdev->dev, "Allocated %d IOQ vectors\n", oct->num_oqs);
    64		return 0;
    65	
    66	free_ioq_vector:
    67		while (i) {
    68			i--;
    69			vfree(oct->ioq_vector[i]);
    70			oct->ioq_vector[i] = NULL;
    71		}
    72		return -1;
    73	}
    74	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org