netdev - Re: [PATCH] net/nfc/nci: use memset avoid infoleaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7fea223-b958-deea-70b2-a649e3cc0ec4@canonical.com>
Date:   Tue, 1 Mar 2022 11:24:02 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Lv Ruyi <cgel.zte@...il.com>
Cc:     chi.minghao@....com.cn, davem@...emloft.net, kuba@...nel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        zealci@....com.cn
Subject: Re: [PATCH] net/nfc/nci: use memset avoid infoleaks

On 01/03/2022 10:34, Lv Ruyi wrote:
> hello sir
> 
> I think this way: On 64-bit systems, struct nci_set_config_param has 
> an added padding of 7 bytes between struct members id and len. Even 
> though all struct members are initialized, the 7-byte hole will 
> contain data from the kernel stack. 
> 

That's reasonable. This explanation should be mentioned in the commit
msg. Also just initialize the array to 0, instead of separate memset call.


Best regards,
Krzysztof