netdev - Re: [PATCH] dpaa2 ethernet switch driver: Fix memory leak in dpaa2_switch_acl_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a87a691a-62c2-5b42-3be8-ee1161281ad8@suse.de>
Date:   Tue, 1 Mar 2022 15:14:16 +0300
From:   Denis Kirjanov <dkirjanov@...e.de>
To:     Q1IQ <fufuyqqqqqq@...il.com>, ioana.ciornei@....com,
        davem@...emloft.net, kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        lyz_cs@....edu.cn
Subject: Re: [PATCH] dpaa2 ethernet switch driver: Fix memory leak in
 dpaa2_switch_acl_entry_add()



3/1/22 12:34, Q1IQ пишет:
> [why]
> The error handling branch did not properly free the memory of cmd_buf
> before return, which would cause memory leak.
> 
> [how]
> Fix this by adding kfree to the error handling branch.
> 
> Signed-off-by: Q1IQ <fufuyqqqqqq@...il.com>

You should use your real name and please add Fixes tag

> ---
>   drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c
> index cacd454ac696..4d07aee07f4c 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c
> @@ -132,6 +132,7 @@ int dpaa2_switch_acl_entry_add(struct dpaa2_switch_filter_block *filter_block,
>   						 DMA_TO_DEVICE);
>   	if (unlikely(dma_mapping_error(dev, acl_entry_cfg->key_iova))) {
>   		dev_err(dev, "DMA mapping failed\n");
> +		kfree(cmd_buff);
>   		return -EFAULT;
>   	}
>   
> @@ -142,6 +143,7 @@ int dpaa2_switch_acl_entry_add(struct dpaa2_switch_filter_block *filter_block,
>   			 DMA_TO_DEVICE);
>   	if (err) {
>   		dev_err(dev, "dpsw_acl_add_entry() failed %d\n", err);
> +		kfree(cmd_buff);
>   		return err;
>   	}
>