[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yh5IdEGC9ggxQ/oy@shredder>
Date: Tue, 1 Mar 2022 18:23:16 +0200
From: Ido Schimmel <idosch@...sch.org>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
John Fastabend <john.fastabend@...il.com>,
Petr Machata <petrm@...dia.com>
Subject: Re: [PATCH net] net: dcb: flush lingering app table entries for
unregistered devices
On Thu, Feb 24, 2022 at 06:01:54PM +0200, Vladimir Oltean wrote:
> +static void dcbnl_flush_dev(struct net_device *dev)
> +{
> + struct dcb_app_type *itr, *tmp;
> +
> + spin_lock(&dcb_lock);
Should this be spin_lock_bh()? According to commit 52cff74eef5d ("dcbnl
: Disable software interrupts before taking dcb_lock") this lock can be
acquired from softIRQ.
> +
> + list_for_each_entry_safe(itr, tmp, &dcb_app_list, list) {
> + if (itr->ifindex == dev->ifindex) {
> + list_del(&itr->list);
> + kfree(itr);
> + }
> + }
> +
> + spin_unlock(&dcb_lock);
> +}
Powered by blists - more mailing lists