netdev - Re: [PATCH bpf-next] bpf: test_run: Fix overflow in xdp frags bpf_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a6333da-f282-09d2-fd2d-cb67e33a07a1@iogearbox.net>
Date:   Tue, 1 Mar 2022 17:33:23 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Stanislav Fomichev <sdf@...gle.com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     ast@...nel.org, andrii@...nel.org,
        Lorenzo Bianconi <lorenzo@...nel.org>
Subject: Re: [PATCH bpf-next] bpf: test_run: Fix overflow in xdp frags
 bpf_test_finish

On 3/1/22 12:23 AM, Stanislav Fomichev wrote:
> Syzkaller reports another issue:
> WARNING: CPU: 0 PID: 10775 at include/linux/thread_info.h:230
> check_copy_size include/linux/thread_info.h:230 [inline]
> WARNING: CPU: 0 PID: 10775 at include/linux/thread_info.h:230
> copy_to_user include/linux/uaccess.h:199 [inline]
> WARNING: CPU: 0 PID: 10775 at include/linux/thread_info.h:230
> bpf_test_finish.isra.0+0x4b2/0x680 net/bpf/test_run.c:171
> 
> This can happen when the userspace buffer is smaller than head+frags.
> Return ENOSPC in this case.
> 
> Fixes: 7855e0db150a ("bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature")
> Cc: Lorenzo Bianconi <lorenzo@...nel.org>
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

Do we have a Reported-by tag for syzkaller so it can match against its report?

Thanks,
Daniel