netdev - Re: [PATCH iproute2-next 1/2] lib: add profinet and ethercat as link layer protocol names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220301115855.53fe4e51@hermes.local>
Date:   Tue, 1 Mar 2022 11:58:55 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     daniel@...unwarth.dev
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next 1/2] lib: add profinet and ethercat as
 link layer protocol names

On Tue, 01 Mar 2022 18:26:10 +0000
daniel@...unwarth.dev wrote:

> February 28, 2022 6:21 PM, "Stephen Hemminger" <stephen@...workplumber.org> wrote:
> > This is legacy table. Original author did choose to use stanard
> > file /etc/ethertypes. Not sure why??  
> 
> I tried to extend /etc/ethertypes with the following line:
> ETHERCAT        88A4    ethercat
> 
> I would expect the following command to successfully run:
> tc filter add dev eno1 protocol ethercat matchall action drop
> 
> Unfortunately all I get is:
> Error: argument "ethercat" is wrong: invalid protocol
> 
> With my patches applied, the command runs without any error.
> 
> 
> I wasn't able to find any hint in the code, where /etc/ethertypes is supposed to be parsed. Could you give me a hint?
> 
> 
> Thanks
> 
> Daniel

Right, iproute2 has its own built in table.

There is nothing that parses and loads ethertypes.
I am suggesting that there ought to read and cache the file; assuming it doesn't slow things down too much.